Skip to content

fix: do not replace headers on fetch requests with error state#13341

Merged
dummdidumm merged 5 commits intosveltejs:mainfrom
aureleoules:fix-error-page-not-sending-headers
Jan 21, 2025
Merged

fix: do not replace headers on fetch requests with error state#13341
dummdidumm merged 5 commits intosveltejs:mainfrom
aureleoules:fix-error-page-not-sending-headers

Conversation

@aureleoules
Copy link
Copy Markdown
Contributor

@aureleoules aureleoules commented Jan 18, 2025 •
edited by teemingc
Loading

Fixes #13340.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 85bef81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aureleoules aureleoules mentioned this pull request Jan 18, 2025
Closed
@teemingc teemingc changed the title Do not replace headers on fetch requests with error state fix: do not replace headers on fetch requests with error state Jan 20, 2025
dummdidumm
dummdidumm reviewed Jan 20, 2025
View reviewed changes
Comment thread packages/kit/src/runtime/server/respond.js
teemingc
teemingc reviewed Jan 21, 2025
View reviewed changes
Comment thread packages/kit/src/runtime/server/respond.js
@dummdidumm @teemingc
Update packages/kit/src/runtime/server/respond.js
c216006 
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
dummdidumm
dummdidumm reviewed Jan 21, 2025
View reviewed changes
Comment thread packages/kit/src/runtime/server/respond.js Outdated
dummdidumm
dummdidumm approved these changes Jan 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit b764298 into sveltejs:main Jan 21, 2025
@github-actions github-actions Bot mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teemingc teemingc teemingc left review comments

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing headers on SSR requests made from an error state to an external backend

3 participants

@aureleoules @dummdidumm @teemingc